refactor(radio): tailwindify #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be 12/14/18 so they pair with 12/14/18 labels and most components which use 12/14/18 type |
|
@julio8a you could use the font size scale from theme to make it explicit this is sized relative to text. Also, since the value is frequently used you could set via a CSS var like we do in other components: :host([scale="s"]) {
--calcite-radio-size: theme("fontSize.-2");
}
:host([scale="m"]) {
--calcite-radio-size: theme("fontSize.-1");
}
:host([scale="l"]) {
--calcite-radio-size: theme("fontSize.1");
}
.radio {
height: var(--calcite-radio-size);
min-width: var(--calcite-radio-size);
max-width: var(--calcite-radio-size);
}This also means that they will scale with the text when users zoom as they'll be in |
|
|
jrowlingson
reviewed
Mar 11, 2021
| box-shadow: inset 0 0 0 1px var(--calcite-ui-border-1); | ||
| cursor: pointer; | ||
| @apply rounded-full cursor-pointer; | ||
| box-shadow: inset 0 0 0 1px var(--calcite-ui-border-input); | ||
| transition: all 0.15s ease-in-out; |
There was a problem hiding this comment.
transition-all duration-150 ease-in-out
jrowlingson
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #1694 #1500
Medium: code and design have 14px, however, tailwind doesn't have this vlaue. Tailwind 2.0 does have it, maybe a reason to update? @jrowlingson
Large: code has 20px, design has 18px (which is not a tailwind value). Used 20px for now.
^^ @bstifle